-
Notifications
You must be signed in to change notification settings - Fork 1
TASK: Neos 9 Compatibility #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Well I updated the PR but custom transformation are right now not possible in Neos 9. |
|
@t-heuser Can you review this PR, after some talks in the Neos-Slack Channel I could update the code to make it work for Neos 9. Thanks 🙏 |
|
Any plans to merge this PR @t-heuser? 🙏 |
|
@paavo @adrian-cerdeira Thanks for the ping, I somehow never got notifications before for this PR, sorry! |
|
@adrian-cerdeira Just had a quick look, your PR also drops Support for Neos 8. Is there any way to keep Neos 8 support and have Neos 9 support at the same time? |
@t-heuser Sadly its not possible. This transformation is completly different in neos 9. |
|
@adrian-cerdeira How long did the transformation took in your use-case? |
@t-heuser Im my use case with only 4 to 10 pages worked fine. Maybe you have some caching trouble or some erros in the logs. But wired enough I cannot remeber having some troubles 🫣. Maybe @paavo can give you here support? |
Right now the installation and use of this package in neos 9 instance fails because of this TODO and the corresponding error:
Required class "Neos\ContentRepository\Migration\Transformations\AbstractTransformation" could not be loaded properly for reflection from "Flowpack\SeoRouting\Migration\Transformation\PropertyValueToLowercase".Can somebody look into this? Thank you